erjemin/instaloader
erjemin/instaloader
1
0
Fork 0
Code Issues Wiki Activity

Fix incorrect error messages when certain requests fail (#1536)

Browse Source 
- handle case where `Profile.from_id` works, but `Profile.from_username` doesn't

- Handle case where `QueryReturnedNotFoundException` lies and `similar_profiles` contains the exact username

- Still raises `ProfileNotExistsException` for compatibility.
This commit is contained in:
Nicolai Weitkemper 2022-05-30 21:29:34 +02:00 committed by GitHub
parent 0704602e50
commit 5a24064012
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
instaloader/instaloader.py
View File

@ -1334,6 +1334,10 @@ class Instaloader:
profile_id)) profile_id))
profile_from_id = Profile.from_id(self.context, profile_id) profile_from_id = Profile.from_id(self.context, profile_id)
newname = profile_from_id.username newname = profile_from_id.username
if profile_name == newname:
self.context.error(
f"Warning: Profile {profile_name} could not be retrieved by its name, but by its ID.")
return profile_from_id
self.context.error("Profile {0} has changed its name to {1}.".format(profile_name, newname)) self.context.error("Profile {0} has changed its name to {1}.".format(profile_name, newname))
if latest_stamps is None: if latest_stamps is None:
if ((format_string_contains_key(self.dirname_pattern, 'profile') or if ((format_string_contains_key(self.dirname_pattern, 'profile') or

3
instaloader/structures.py
View File

@ -771,6 +771,9 @@ class Profile:
top_search_results = TopSearchResults(self._context, self.username) top_search_results = TopSearchResults(self._context, self.username)
similar_profiles = [profile.username for profile in top_search_results.get_profiles()] similar_profiles = [profile.username for profile in top_search_results.get_profiles()]
if similar_profiles: if similar_profiles:
if self.username in similar_profiles:
raise ProfileNotExistsException(
f"Profile {self.username} seems to exist, but could not be loaded.") from err
raise ProfileNotExistsException('Profile {} does not exist.\nThe most similar profile{}: {}.' raise ProfileNotExistsException('Profile {} does not exist.\nThe most similar profile{}: {}.'
.format(self.username, .format(self.username,
's are' if len(similar_profiles) > 1 else ' is', 's are' if len(similar_profiles) > 1 else ' is',